[Fong Yih Jie] iP #487

fongyj · 2022-08-27T09:37:22Z

DukePro

"Your mind is for having ideas, not holding them." – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 🤨

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Duke duke = new Duke();
    }
}

Add Gradle support

# Conflicts: # src/main/java/duke/Storage.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java

# Conflicts: # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java

kelvinou01

Overall, the PR was pretty good, and adhered to the style guide! There were only some minor issues that I would like you to go over. Good job!

kelvinou01 · 2022-09-01T00:42:08Z

src/main/java/duke/Duke.java

+    protected TaskList tasks;
+    protected Parser parser;
+
+    private boolean runningDuke;


Would a proposition be a clearer name for this boolean? (e.g. dukeIsRunning ?)

kelvinou01 · 2022-09-01T00:45:18Z

src/main/java/duke/Parser.java

+     * @param verbose Boolean to indicate verbosity of Ui.
+     * @throws DukeException If command cannot be parsed or is invalid.
+     */
+    public void parse(String command, boolean verbose) throws DukeException {


Would a proposition be a clearer name for the boolean parameter? (e.g. isVerbose)?

kelvinou01 · 2022-09-01T00:50:23Z

src/main/java/duke/Parser.java

+     * @throws DukeException If command cannot be parsed or is invalid.
+     */
+    public void parseTwo(String command) throws DukeException {
+        String[] split = command.split(" ", 2);


Would a plural name be a better name for an array?

kelvinou01 · 2022-09-01T00:53:14Z

src/main/java/duke/Parser.java

+        String[] split = command.split(" ", 2);
+        String commandName = split[0];
+        int id = tasks.getSize();
+        if (split.length > 1){


Nothing major, but whitespace between ){ would be nice! May I suggest running checkStyle before submitting, it has made my life a lot easier!

kelvinou01 · 2022-09-01T00:53:42Z

src/main/java/duke/Parser.java

+     * @throws DukeException If command cannot be parsed or is invalid.
+     */
+    public void parseFind(String command) throws DukeException {
+        String[] split = command.split(" ", 2);


Same as above

kelvinou01 · 2022-09-01T00:56:05Z

src/main/java/duke/TaskList.java

+ * Class that stores and manipulates tasks for Duke Bot.
+ */
+public class TaskList {
+    protected final ArrayList<Task> taskList;


Would a name like tasks be more concise?

kelvinou01 · 2022-09-01T00:59:03Z

src/main/java/duke/task/Task.java

+    /**
+     * Marks current Task as done.
+     */
+    public void done() {


Will a verb be more apt for this method name?

kelvinou01 · 2022-09-01T00:59:16Z

src/main/java/duke/task/Task.java

+    /**
+     * Marks current Task as not done.
+     */
+    public void undone() {


Same as above

ErvinK123

A few nits when naming variables, nothing major, should be good to merge when changed. 👍

ErvinK123 · 2022-09-01T12:23:17Z

src/main/java/duke/Ui.java

+                             + "| |_| | |_| |   <  __/\n"
+                             + "|____/ \\__,_|_|\\_\\___|\n";
+    private Scanner sc;
+    private boolean verbose;


Perhaps a more intuitive variable name here?

ErvinK123 · 2022-09-01T12:25:31Z

src/main/java/duke/task/EventTask.java

+     */
+    public EventTask(String description) throws DateTimeParseException, DukeException {
+        super();
+        this.commandString = description;


Perhaps an overloaded constructor for superclass Task can be looked into

ErvinK123 · 2022-09-01T12:30:02Z

src/main/java/duke/Storage.java

+ * Class that handles loading and saving of tasks for Duke Bot.
+ */
+public class Storage {
+    private FileWriter output;


Perhaps a more intuitive name could be used, that suggests the attribute is a filewriter

Included some assertions in Parser, Task and Storage class. These assertions should help to flag out bugs in these classes during runtime.

Improved on quality of code according to code quality guide. Removed instances of magic number and revised bad variable naming. This makes the code easier to read.

Add assertions

# Conflicts: # src/main/java/duke/Storage.java

Branch a code quality

Used a HashSet to store task strings for duplicate checking. Checking for duplicate via a HashSet is faster than checking for duplicates by iterating through an ArrayList.

Find command used to search using toString method of the tasks. This will include (by:...) and (at:...) in the search. This will mean that "find y" will return all deadlines and "find (" will return all deadlines and events.

Storage used to save only after bye command. Now save after every modification to task list. Also updated storage file chick.txt to not store uncheck command as it is redundant. Duplicate check was missing in the implementation of removing the task from duplicate check after deleting the task from task list.

Changed backslash in userguide to forward slash.

damithc and others added 24 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add echo and bye functionality

5fe9e8b

Add add and list functionality

9196067

Add mark and unmark functionality

229e2b6

Add todo, event and deadline tasks

bba21b5

Add text ui testing

a5853db

Add error handling

451c8c4

Add delete and more exception handling

9f055d3

Add save and load

96a42de

Add date parsing

1d025c3

Merge branch 'branch-Level-7'

6f44176

Merge branch 'branch-Level-8'

d66ebf3

Refactor for more OOP

4ba2c39

Organise classes into packages

5f01979

Merge pull request #1 from nus-cs2103-AY2223S1/add-gradle-support

e403f32

Add Gradle support

Add gradle support

2c5047d

Add JUnit tests

3eff73f

Add Jar file

f3a012d

Add JavaDoc

b0612c7

Refactor for coding standard

70f4be4

Add find feature

8f83e41

Merge branch 'branch-A-JavaDoc'

b19f0f7

Merge branch 'branch-A-CodingStandard'

fd033e9

# Conflicts: # src/main/java/duke/Storage.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java

Merge branch 'branch-Level-9'

6e94db0

# Conflicts: # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java

kelvinou01 reviewed Sep 1, 2022

View reviewed changes

ErvinK123 reviewed Sep 1, 2022

View reviewed changes

fongyj added 4 commits September 2, 2022 05:23

Refactor for coding style

29e0808

Add checkstyle and corrected style

f1c27bd

Add GUI with javafx

12236b0

Add handling of invalid index for mark, unmark and delete commands

fff3258

fongyj and others added 30 commits September 11, 2022 18:14

Merge branch 'branch-Level-10'

f1bd19f

Add assertions

02a0d9b

Included some assertions in Parser, Task and Storage class. These assertions should help to flag out bugs in these classes during runtime.

Improve code quality

16a6b77

Improved on quality of code according to code quality guide. Removed instances of magic number and revised bad variable naming. This makes the code easier to read.

Merge pull request #3 from fongyj/branch-A-Assertions

c5e8e21

Add assertions

Merge branch 'master' into branch-A-CodeQuality

2884196

# Conflicts: # src/main/java/duke/Storage.java

Merge pull request #4 from fongyj/branch-A-CodeQuality

5017077

Branch a code quality

Add C-DetectDuplicates functionality

d2083aa

Merge branch 'branch-BCD-Extension'

1a9d966

Optimised duplicate task checking

5e510ca

Used a HashSet to store task strings for duplicate checking. Checking for duplicate via a HashSet is faster than checking for duplicates by iterating through an ArrayList.

Implemented chick personality

e21f213

Merge branch 'branch-A-Personality'

11a7a10

Add help command

1ef6bfb

Update javafx UI

cfa63ae

Update javafx UI again

5a9eec1

Correct style and add Ui image

1816df3

Add README.md for Chick Bot

7913543

Update UI and personality

218d762

Update Ui.png

e9ff7b7

Update date parsing error and add close window on bye

e4f62af

Fix deadline and event task error mesesage

1390bfc

Rename Ui.png

2a3e9c4

Add Ui.png

611d04a

Remove Ui.png

df9bcb1

Fix task loading implementation issue

b1277d5

Remove unused image

352de77

Fix find command bug

cf229e0

Find command used to search using toString method of the tasks. This will include (by:...) and (at:...) in the search. This will mean that "find y" will return all deadlines and "find (" will return all deadlines and events.

Merge branch 'master' of https://github.com/fongyj/ip

01a7b7c

Fix user guide

ec2c08d

Changed backslash in userguide to forward slash.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fong Yih Jie] iP #487

[Fong Yih Jie] iP #487

fongyj commented Aug 27, 2022 •

edited

Loading

kelvinou01 left a comment

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

kelvinou01 Sep 1, 2022

ErvinK123 left a comment

ErvinK123 Sep 1, 2022

ErvinK123 Sep 1, 2022

ErvinK123 Sep 1, 2022

[Fong Yih Jie] iP #487

Are you sure you want to change the base?

[Fong Yih Jie] iP #487

Conversation

fongyj commented Aug 27, 2022 • edited Loading

DukePro

kelvinou01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ErvinK123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fongyj commented Aug 27, 2022 •

edited

Loading